fix(firestore): re-enable surefire in native profile for admin client - #14291
Draft
dlarocque wants to merge 1 commit into
Draft
fix(firestore): re-enable surefire in native profile for admin client#14291dlarocque wants to merge 1 commit into
dlarocque wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a native profile to the pom.xml file in the google-cloud-firestore-admin module. The reviewer advises against manually editing this file as it is auto-generated and changes will be overwritten, suggesting instead to modify the generator or source metadata.
Comment on lines
+152
to
+157
| <profile> | ||
| <id>native</id> | ||
| <properties> | ||
| <skipUnitTests>false</skipUnitTests> | ||
| </properties> | ||
| </profile> |
Contributor
There was a problem hiding this comment.
Avoid manually editing auto-generated files (such as pom.xml in generated client libraries) because changes will be overwritten. Modify the generator or the source metadata instead.
References
- Avoid manually editing auto-generated files (such as pom.xml in generated client libraries) because changes will be overwritten. Modify the generator or the source metadata instead.
dlarocque
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Override
skipUnitTestsback tofalseunder thenativeprofile ingoogle-cloud-firestore-admin/pom.xmlso Surefire generates the test configuration required bynative-maven-pluginduring GraalVM builds.Fixes build errors in CI that are currently happening in main example