Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements support for converting BigQuery STRUCT columns into nested Protobuf messages. It introduces recursive descriptor generation, handles nested error path propagation (e.g., a.b), avoids naming collisions with sibling columns, and adds comprehensive unit tests to validate these behaviors. I have no feedback to provide as the implementation is clean, robust, and conforms to the repository style guidelines.
haphungw
marked this pull request as ready for review
November 13, 2026 21:46
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7463 +/- ##
=======================================
Coverage 98.60% 98.60%
=======================================
Files 338 338
Lines 148237 148319 +82
=======================================
+ Hits 146172 146253 +81
- Misses 2065 2066 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
haphungw
marked this pull request as draft
November 13, 2026 22:10
haphungw
force-pushed
the
bq-json-pr04-struct-columns
branch
from
November 14, 2026 02:01
137bfed to
13ca964
Compare
haphungw
marked this pull request as ready for review
November 14, 2026 02:04
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert BigQuery
STRUCTcolumns into nestedDescriptorProtomessages inroot.nested_type.In BigQuery, a
STRUCTcolumn stores its subfields inline onTableFieldSchema.fields. In protobuf, aFieldDescriptorProtocan't hold subfields inline: instead, the field setstype = TYPE_MESSAGEandtype_name = "m1", androot.nested_typeholds theDescriptorProtonamed"m1"with those subfields.For
(id INT64, address STRUCT<city STRING>), this produces the equivalent of:Towards #6783