Repository navigation
fix: Fail open on any error resolving the project ID in the ADK framework. - #7256
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
product-auto-label
Bot
added
size: m
…work. `AdkApp` converts a project number into a project ID with a Cloud Resource Manager call during `set_up()`, but tolerated only `PermissionDenied` and `Unauthenticated`. Any other failure -- including `google-cloud-aiplatform` not being installed, which surfaced as `UnboundLocalError` -- stopped the agent from starting. The lookup is cosmetic, so it now falls back to the project number on any error and logs a warning. FUTURE_COPYBARA_INTEGRATE_REVIEW=#7235 from googleapis:release-please--branches--main fe718d1 PiperOrigin-RevId: 1010226096
copybara-service
Bot
force-pushed
the
copybara_1010226096
branch
from
October 30, 2026 05:33
bce3960 to
31bfdf5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Fail open on any error resolving the project ID in the ADK framework.
AdkAppconverts a project number into a project ID with a Cloud ResourceManager call during
set_up(), but tolerated onlyPermissionDeniedandUnauthenticated. Any other failure -- includinggoogle-cloud-aiplatformnot being installed, which surfaced as
UnboundLocalError-- stopped theagent from starting. The lookup is cosmetic, so it now falls back to the
project number on any error and logs a warning.
FUTURE_COPYBARA_INTEGRATE_REVIEW=#7235 from googleapis:release-please--branches--main fe718d1