Repository navigation
fix: use the given project and location for feature store parent paths - #7261
Open
abhishekacharya200 wants to merge 1 commit into
Open
abhishekacharya200 wants to merge 1 commit into
abhishekacharya200 wants to merge 1 commit into
Conversation
Feature, FeatureMonitor and FeatureView built the parent path from aiplatform.init, so a project or location passed with a short parent id was ignored.
product-auto-label
Bot
added
size: m
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7260
Feature,FeatureMonitorandFeatureViewacceptprojectandlocation, but when the parent was given as a short id they built the parent path withutils.full_resource_namewithout those two values. The request then went to the project and location fromaiplatform.init.This passes
projectandlocationtofull_resource_namein all three classes. Callers who don't set them still get theaiplatform.initvalues, because that's whatfull_resource_namefalls back to.Added one test per class that sets different values in
aiplatform.initand in the constructor, and checks the requested name. All three fail onmainand pass with this change.test_vertexai_feature.py,test_vertexai_feature_monitor.pyandtest_vertexai_feature_view.pypass (58 passed), with the service clients mocked. black 24.8.0 and flake8 6.1.0 report nothing on the changed files.