Repository navigation
fix(route): persist OrderStatus=valid inside RetryOnConflict and reset failures - #18
Merged
wgordon17 merged 1 commit intoOct 18, 2026
Conversation
…t failures Calls setStatus(&freshRoute.ObjectMeta, status) inside RetryOnConflict when persisting a newly issued certificate so the Route annotation does not retain stale OrderStatus="ready", which previously caused the next reconcile to hit the orphaned-Valid-order path and increment Failures. Also resets status.ProvisioningStatus.Failures and OrderError on successful certificate issuance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setStatus(&freshRoute.ObjectMeta, status)onfreshRouteinside theRetryOnConflictloop when persisting a newly issued certificate (and remove the dead pre-retryroute.DeepCopy()block) soOrderStatus: "ready"is not left on the Route annotation after issuancestatus.ProvisioningStatus.Failures = 0andOrderError = nilwhen a certificate is successfully issued so post-issuance reconciles go straight to scheduling the renewal requeue without logging a spuriousOrder is Valid but we lack the private keywarning or incrementingFailuresTestSync_ReadyOrderPersistsStatusAndResetsFailuresunit test covering the two-stepStatusReadyfinalization and subsequent settled reconcile