Skip to content

fix(route): persist OrderStatus=valid inside RetryOnConflict and reset failures - #18

Merged
wgordon17 merged 1 commit into
gordon-code:mainfrom
wgordon17:fix/persist-status-on-cert-update
Oct 18, 2026
Merged

wgordon17 merged 1 commit into
gordon-code:mainfrom
wgordon17:fix/persist-status-on-cert-update

Conversation

@wgordon17

Copy link
Copy Markdown
Member

Summary

  • Call setStatus(&freshRoute.ObjectMeta, status) on freshRoute inside the RetryOnConflict loop when persisting a newly issued certificate (and remove the dead pre-retry route.DeepCopy() block) so OrderStatus: "ready" is not left on the Route annotation after issuance
  • Reset status.ProvisioningStatus.Failures = 0 and OrderError = nil when a certificate is successfully issued so post-issuance reconciles go straight to scheduling the renewal requeue without logging a spurious Order is Valid but we lack the private key warning or incrementing Failures
  • Add TestSync_ReadyOrderPersistsStatusAndResetsFailures unit test covering the two-step StatusReady finalization and subsequent settled reconcile

…t failures

Calls setStatus(&freshRoute.ObjectMeta, status) inside RetryOnConflict
when persisting a newly issued certificate so the Route annotation does
not retain stale OrderStatus="ready", which previously caused the next
reconcile to hit the orphaned-Valid-order path and increment Failures.
Also resets status.ProvisioningStatus.Failures and OrderError on
successful certificate issuance.
@wgordon17
wgordon17 marked this pull request as ready for review October 18, 2026 14:21
@wgordon17
wgordon17 requested a review from a team October 18, 2026 14:21
@wgordon17
wgordon17 merged commit ca433cc into gordon-code:main Oct 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant