Skip to content

feat: show pending resource replacement in the toolbar - #1273

Open
Maxxich wants to merge 1 commit into
feat/resource-replacement-editorfrom
feat/resource-replacement-ui
Open

Maxxich wants to merge 1 commit into
feat/resource-replacement-editorfrom
feat/resource-replacement-ui

Conversation

@Maxxich

@Maxxich Maxxich commented Sep 24, 2026 •

Copy link
Copy Markdown

Depends on PR: feat: connect resource replacement to the editor lifecycle.

Show a single toolbar spinner while resource replacement requests are pending,
including custom toolbar configurations. Add a demo and document the indicator.
Cover the default, custom and mobile toolbar while requests complete or are cancelled.
Register the resource guide in the generated documentation, repair its toolbar
backlink and apply the required demo formatting. The library implementation matches
the fixed reference; the approved documentation/formatting changes and additional
tests are documented in REPORT.md.

Summary by Sourcery

Display pending resource replacement activity in the editor toolbar and provide documentation, demonstrations, and coverage for the behavior.

New Features:

  • Show a single pending resource replacement spinner in the main toolbar across editor modes, custom toolbar configurations, overflow states, and mobile layouts.
  • Add an interactive resource replacement demo covering image and file resources, completion, cancellation, and concurrent operations.

Bug Fixes:

  • Keep the resource replacement indicator visible until all pending operations have completed or been cancelled.
  • Stabilize link visual test cursor placement.

Enhancements:

  • Extend the flexible toolbar with support for reserving space for status content alongside toolbar items.

Documentation:

  • Document the resource replacement toolbar indicator and link the resource replacement guide from toolbar customization documentation.
  • Register the resource replacement guide in the generated documentation hierarchy and repair its toolbar backlink.

Tests:

  • Add visual coverage for default, custom, and mobile toolbars in both WYSIWYG and markup modes, including concurrent requests, cancellation, and completion.

Chores:

  • Apply required resource replacement demo formatting updates.

@gravity-ui

gravity-ui Bot commented Sep 24, 2026

Copy link
Copy Markdown

Storybook Deployed

@gravity-ui

gravity-ui Bot commented Sep 24, 2026

Copy link
Copy Markdown

🎭 Playwright Report

@Maxxich
Maxxich marked this pull request as ready for review September 24, 2026 10:56

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @Maxxich, your pull request is larger than the review limit of 150,000 diff characters

@Maxxich
Maxxich changed the base branch from main to feat/resource-replacement-editor October 5, 2026 09:07
@d3m1d0v
d3m1d0v added this pull request to stack #1320 October 5, 2026 13:17

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant