Skip to content

Adjust badge colors on computation run button - #4289

Merged
ayolab merged 1 commit into
mainfrom
ayolab/adapt-run-button-badge-colors
Oct 29, 2026
Merged

ayolab merged 1 commit into
mainfrom
ayolab/adapt-run-button-badge-colors

Conversation

@ayolab

@ayolab ayolab commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b16ebaa2-8acd-4c3f-b265-7b99f24bfa22
Commits

Reviewing files that changed from the base of the PR and between 325e0bf and 9a64528.

Files selected for processing: 1
  • src/components/utils/split-button.tsx

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

SplitButton now computes badge background and text colors using the theme mode and status color. The status-color helper has an explicit return type, and the badge applies its color through merged styles.

Changes: SplitButton badge styling

Layer / File(s) Summary
Compute and apply badge colors
src/components/utils/split-button.tsx
Adds theme-aware badge background and text colors. Types getBadgeColor as BadgeColor and applies the computed status color through merged badge styles.

Suggested reviewers: etiennelt

Priority: Low

Merge Risk: Minimal · up to 9a645

The badge contrast meets the applicable readability threshold, so no actionable merge risk remains.

Pre-merge checks: Passed 4 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Description check Inconclusive No pull request description was provided, so the description does not convey meaningful information about the changeset. Add a brief description that explains how the badge colors change on the computation run button.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly describes the main change: adjusting badge colors on the computation run button.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@souissimai
souissimai self-requested a review October 29, 2026 14:38
@ayolab
ayolab merged commit 32cdcda into main Oct 29, 2026
5 checks passed
@ayolab
ayolab deleted the ayolab/adapt-run-button-badge-colors branch October 29, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants