Repository navigation
fix(background-subagent): keep card alive across turn for V1 background subagents - #264
Merged
Merged
Conversation
…nd subagents - FIX-BGSUB: V1 background subagents retired at turn boundary The gate now accepts running OR completed and input.background OR metadata.background; a background intent keyed by child session id is retained until the card attaches (task part can precede session.created); isBackgroundTool also honors metadata.background.
Contributor
Author
|
@grinev can you review and merge this? im make a litle plugin that make auto set subagent into background process like V2 behavior and its work for me, maybe usefull for other, Thanks. |
Owner
|
@vheins thanks for contribution! I didn't know that opencode V1 also has background subagents |
Contributor
Author
Thanks, its experimental feature and must be activated with env |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
tool.running+input.background, socompletedstates andmetadata.backgroundpayloads were dropped. The next turn cleared the pending card before the child card could attach.Fix
src/app/managers/summary-aggregation-manager.ts: acceptrunning|completedandinput.background|metadata.background; retain background intent until the child card attaches instead of clearing eagerly.src/bot/events/handlers/tool-activity-handler.ts:isBackgroundToolhonorsmetadata.backgroundin addition toinput.background.Tests
tests/app/managers/summary-aggregation-manager.test.tscoveringrunning→completedtransitions and bothinput.background/metadata.backgroundsignals.