Repository navigation
442: opskit go picker — aligned columns, no timeout - #443
Merged
growlf merged 3 commits intoOct 13, 2026
Merged
Conversation
Owner
Author
|
Reviewed. Reproduced both defects against the current code and confirmed the fix.
Tests cover the header, column alignment (offsets match), the No blocking issues. Nit only: branch/dirty are recomputed for the selected row on the confirmation screen — negligible for an enabled list. Merging. |
growlf
deleted the
442-opskit-go-picker-has-no-column-layout-and-times-ou
branch
October 13, 2026 22:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #442
What & why
opskit go's fzf picker was hard to read and could self-terminate:f"{rel}\t{path}"with no header and no fixed widths, so the tab expanded to a tab stop and the long absolute path dominated each line.timeout=60; waiting longer killed it, printed "fzf not found or timed out", and exited 1.Changes (
bin/opskit-go.py)_picker_header(),_picker_row(proj, git_lookup),build_picker(projects, git_lookup=_git_info). Rows are space-padded to fixed widths with a header:NAME | BRANCH | STATUS | RESUME; long values truncate with….run_fzf_selectionto use--delimiter=\t --with-nth=2 --accept-nth=1 --header=<header>: display the aligned columns, return the hidden path (field 1). The path is parsed with a.split("\t")[0]fallback so it works even on a build that ignores--accept-nth.None). fzf-missing still errors clearly._git_infofor the displayed (enabled) rows only, so the scan stays cheap.Verification
tests/test_tui_picker.py: header names the columns; header/row column offsets align;[resume]only when present; long names truncate to width; each line's field 1 is the path;run_fzf_selectionpasses notimeoutand passes the column options; cancel/empty selection returnNone.make test→ 1685 passed, 1 skipped.Plan:
plans/442-opskit-go-picker-columns.md.