Repository navigation
Conversation
Fixtures named temp roots from the process ID and the wall clock. macOS reads SystemTime in whole microseconds (node::now counts milliseconds), so two tests that cargo test starts together can compute the same root. With a non-exclusive create (state::private_directory is recursive) the second fixture reuses the first one's root: it finds the other test's provider lock held, and the first fixture's Drop removes the root under it (hostname_authority::managed, CI signature provider_busy at :111 and NotFound at :146). Add a test-only crate::unique_test_root / private_test_root helper: the name is <prefix>-<pid>-<process-wide sequence>, made with one exclusive, non-recursive mkdir; a name left by an earlier process with the same pid is skipped, never reused. Switch the lib fixtures that named roots from pid alone or pid plus clock to it. Fixtures that #399 also changes take #399's identical edit (crate::next_test_scratch appended), so the two branches merge cleanly in either order. Refs HACK-1393 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ed helper The host relay control fixture named its /tmp root from the process ID alone, so a second root in the same process (the live test's other owner root) or a root left by an earlier process with the same ID failed the exclusive create. Take both roots from crate::private_test_root, which keeps the 0700 exclusive create, and record the identity as before. Refs HACK-1393 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration gate for merge batch b51: origin/next + #461 (HACK-1393). Tree 42ae5146. Closed after the batch squashes.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.