Make Dependency required: real and add Overview guidance to blank forms - #183
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes part of hackforla/devops#187.
Two fixes to both blank issue forms:
blank-issue-form-with-dependency.yml: the Dependency field'svalue: '- [ ]'becomesplaceholder: '- [ ]'.value:prefills the textarea, so it was never empty and therequired: truebelow it could never fail — the form could be submitted with a bare unchecked box and no blocker listed.placeholder:shows the same hint without putting it in the submitted body.placeholder:, copied verbatim fromhackforla/devops'sblank-issue-form.yml, so all three repos share one wording. The convention only ever appeared inblank-issue-template.md, deleted in Remove redundant blank issue template #162.The same commit goes to the other repo so the two files stay byte-identical — verified with
cmpafter the edit, both files clean.Not observable until this merges: GitHub renders issue templates from the default branch only.