Repository navigation
Prepare for Elemental2 1.4.0 - #382
Draft
treblereel wants to merge 1 commit into
Draft
treblereel wants to merge 1 commit into
treblereel wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Elemental2 1.4.0 changes
HTMLElement.hiddenfrom a boolean to a boolean/string union. This prepares Elemento for that API by updating the dependency to1.4.0-RC2and wrapping assignments withHTMLElement.HiddenUnionType.of(hidden), preserving the existing boolean behavior.This PR intentionally uses Elemental2 1.4.0-RC2 while the final release is pending. It will be updated to 1.4.0 as soon as the final release is available.
Validation: built and installed the BOM plus
core,svg, and their reactor dependencies withmvn -pl core,svg -am install -DskipTests. The resulting Elemento snapshot was also used successfully in downstream J2CL ADVANCED builds of Crysknife and the Serverless Workflow Diagram Editor. Tests were skipped; browser behavior was not checked.