Repository navigation
fix(cmake): verify CBLAS symbols link, not just that cblas.h exists - #257
Merged
Merged
Conversation
find_package(BLAS) can pick a Fortran-only BLAS (Netlib libblas on Arch/Fedora) while cblas.h comes from a separate cblas package. A shared libtranscribe then links with cblas_* unresolved and dies at runtime with 'undefined symbol: cblas_sgemm' (cjpais/Handy#2274). Check that cblas_sgemm/cblas_sgemv actually link against BLAS_LIBRARIES; if not, try the separate libcblas, otherwise fall back to the scalar path with a configure warning. Also look for cblas.h under include/openblas/, where Arch and Fedora put it, so those OpenBLAS installs stop silently falling back to the scalar decoder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.