FE-1793: Scope destructive model-edit approval to one conversation - #9856
Open
kostandinang wants to merge 15 commits into
Open
kostandinang wants to merge 15 commits into
kostandinang wants to merge 15 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This was referenced Sep 28, 2026
kostandinang
force-pushed
the
ka/fe-1793-conversation-permissions
branch
from
September 28, 2026 17:19
29ef0d7 to
aaffa2d
Compare
kostandinang
added this pull request to stack #9861
September 28, 2026 18:43
3 of 5 tasks
kostandinang
force-pushed
the
ka/fe-1793-conversation-permissions
branch
from
September 28, 2026 19:19
1aee06a to
59e656d
Compare
kostandinang
removed this pull request from stack #9861
September 28, 2026 19:19
kostandinang
added this pull request to stack #9863
September 28, 2026 19:19
kostandinang
marked this pull request as ready for review
September 28, 2026 21:31
kostandinang
force-pushed
the
ka/fe-1793-conversation-permissions
branch
from
September 29, 2026 20:45
7daefd2 to
7d66dc5
Compare
Destructive canonical Petrinaut calls from Brunch, every remove tool and deleteItemsByIds, wait for approval inside their in-band browser call turn, so later calls stay queued behind them. Allow runs the call, Deny settles it as not applied so Brunch accepts the result instead of failing the follow-up, and Stop cancels a pending approval. An inline approval lists the requested removals while the call waits. Clear AI chat in ordinary Brunch starts a fresh, persisted conversation and resets conversation-only approvals without replacing the model or deleting old history. Always allow lasts only for the current mounted conversation until leaving or reloading. Keep experiment lifecycle work in the next layer and leave stock approvals unchanged. Refs FE-1793
Every destructive tool was registered as interactive, so its widget replaced the normal tool row everywhere: rows went blank while a call was claimed or after a decision, and completed deletions lost their usual tool row. The approval is now registered only for tools with a call waiting on the coordinator; every other row keeps its normal presentation.
Approval widgets were matched by tool name, so while one removal waited, earlier rows of the same tool swapped to the widget until the decision settled. Petrinaut interactive tools can now choose which validated inputs they handle, and the approval matches only the input of the call waiting on the coordinator.
…picking a row Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: Amp <amp@ampcode.com>
…ation Co-authored-by: Cursor <cursoragent@cursor.com>
lunelson
reviewed
Sep 30, 2026
kube
previously approved these changes
Sep 30, 2026
Co-authored-by: Amp <amp@ampcode.com>
lunelson
previously approved these changes
Sep 30, 2026
lunelson
left a comment
Contributor
There was a problem hiding this comment.
Thanks — all threads addressed. Per-call Deny is fine as documented.
3 of 4 tasks
kube
previously approved these changes
Sep 30, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6334ad6. Configure here.
Document that shouldHandle only suppresses the widget for tools the host executes itself, and name the declined call instead of reporting a registered tool as unknown. Refs FE-1793 Co-authored-by: Cursor <cursoragent@cursor.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

🌟 What is the purpose of this PR?
Require approval before Brunch performs destructive model edits, and provide a fresh-conversation action that resets this authority without deleting the model or saved history.
🔗 Related links
🚫 Blocked by
ka/fe-1793-conversation-ui.Stack: main → #9829 → this PR → #9857 → #9836. Voice steering #9826 is independent. This layer includes the consent, floating-minimize and Voice recovery fixes from presentation.
🔍 What does this change?
Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
@hashintel/petrinaut's input-selective interactive-tool API.📜 Does this require a change to the docs?
🕸️ Does this require a change to the Turbo Graph?
unauthorized: access to the requested resource is not authorized); this is not a result for the current head.🐾 Next steps
Review as a complete permission feature. Experiment lifecycle follows but does not supply approval authority. The history-fixture fix is retained.
🛡 What tests cover this?
git diff --checkpassed.❓ How to test this?
turbo run build test:unit lint:tsc lint:eslint --filter @hashintel/petrinaut --filter @apps/petrinaut-website.brunch-mutation-approval,brunch-petrinaut-tools, registry andlocal-storage-demo-apptest files.📹 Demo
Controlled fixture using the production approval widget; no model is invoked and no mutation is executed.
Approval interaction
pr-9856-approval-interaction.mp4