Repository navigation
uninstall and install.sh: remove only miso's own files - #24
Merged
Merged
Conversation
miso uninstall removed the whole folder two levels above the binary when it held a bin/miso. Installed as /usr/local/bin/miso (with /usr/local/mhs-*), it removed all of /usr/local. install.sh removed $MISO_HOME/bin as a whole, so MISO_HOME=$HOME removed ~/bin and every program in it; it listed them first, but --yes, and an install without a terminal, did not ask. Both now remove only what miso put there: bin/miso and bin/cpphs (and .exe), the package databases mhs-VERSION/, and in $MISO_HOME the caches (mcabal/, src/, store/, rts/). A folder that holds nothing else is removed with them, as before. In a folder that holds other things, only miso's files go; the caches' generic names are left there, as they may not be miso's. Checked by hand with the built tool and a local release: - a /usr/local-like folder: before, all of it was removed; now bin/miso, bin/cpphs and mhs-* go, and bin/node, share/ and src/ stay - ~/.miso: everything goes, and the folder too (as before) - MISO_HOME with the user's own src/: their src/ and bin/mytool stay - install.sh with MISO_HOME=$HOME: before, ~/bin/mytool was removed; now it stays
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
miso uninstalldeleted the whole folder two levels above the binary whenever it contained abin/miso. If miso was installed as/usr/local/bin/miso(with/usr/local/mhs-*), uninstall deleted all of/usr/local.install.shdeleted$MISO_HOME/binas a whole, soMISO_HOME=$HOMEdeleted~/binand every program in it. It listed them first, but--yes, and installs without a terminal (curl … | shin CI), don't ask.Now both remove only what miso put there:
bin/miso,bin/cpphs(and.exe), the package databasesmhs-VERSION/, and in$MISO_HOMEthe caches (mcabal/,src/,store/,rts/).src/,store/) are left there too, since they may not be miso's.Checked with the built tool and a local release:
/usr/local-like folder withbin/node,share/,src/bin/miso,bin/cpphs,mhs-*removed~/.misoMISO_HOMEwith the user's ownsrc/andbin/mytoolMISO_HOME=$HOMEinstall.sh --yeswithMISO_HOME=$HOME~/bin/mytooldeletedGenerated by Claude Code