Repository navigation
miso clean: only in a project, and never $MISO_HOME - #27
Merged
Merged
Conversation
miso clean removed dist/, public/ and .miso/ from whatever folder it ran in, with no miso.yml needed. In the home folder that removed ~/.miso, the miso installation; in another kind of project, its public/ and dist/. It now runs only where there is a miso.yml, and leaves .miso/ alone when it is $MISO_HOME or where the tool is installed (a project in ~ itself). Checked with the built tool: - in a home folder with ~/.miso and a public/ site: before, both were removed; now it stops with an error and removes nothing - in a project: dist/, public/ and .miso/ are removed, as before - a project in the home folder: dist/ and public/ go, ~/.miso stays
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug:
miso cleanremoveddist/,public/and.miso/from whatever folder it ran in. It never checked for amiso.yml. In the home folder that deleted~/.miso, the whole miso installation. In another kind of project, it deleted that project'spublic/anddist/.The fix:
miso.yml; anywhere else it stops with an error and removes nothing..miso/alone when that folder is$MISO_HOMEor where the tool is installed. That's the case for a project in~itself.Checked with the built tool:
~/.misoand apublic/sitedist/,public/,.miso/removed~/.misodist/andpublic/removed,~/.misokeptGenerated by Claude Code