Repository navigation
miso update: actually update the package list - #28
Merged
Merged
Conversation
miso update ran "miso mcabal update" with CABALDIR set to $MISO_HOME/mcabal, but the child set CABALDIR again from the project it ran in (MISO_PROJECT, which this process had set). So the new Stackage list went to the project's .miso/mcabal, the old shared list was then copied back over it, and versions never moved, while it said "Updating the package list". The update now runs in $MISO_HOME/mcabal with MISO_PROJECT cleared, so the child uses the shared list. Checked with the built tool and a stand-in curl that serves a snapshot with split 9.9.9 (the shared list had split 0.1.0): before, both lists still had 0.1.0 and the snapshot was downloaded into the project's .miso/; now both have 9.9.9, downloaded into $MISO_HOME/mcabal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug:
miso updateprinted "Updating the package list", but versions never moved.Why:
miso mcabal updateresetCABALDIRfrom the project it ran in (via the inheritedMISO_PROJECT)..miso/mcabal.$MISO_HOME/mcabalwas then copied back over it.The fix: the update now runs in
$MISO_HOME/mcabalwithMISO_PROJECTcleared, so the child writes the shared list.Checked with the built tool and a stand-in
curlserving a snapshot withsplit 9.9.9, starting from a shared list withsplit 0.1.0:.miso/.$MISO_HOME/mcabal.Stackage itself isn't reachable from where I tested, so this PR's CI and a real
miso updateare the end-to-end check.Generated by Claude Code