Repository navigation
Unpacked library sources: named by checksum, not only version - #29
Merged
Merged
Conversation
… version The source of a library that comes with the tool (and the release's miso) was unpacked in $MISO_HOME/src/bundled/mhs-VERSION/NAME-VERSION, and reused when that was there. src/ outlives an upgrade, and a new release can ship another source of the same version: miso at another commit, still 1.14.0.0. Then the old source was used: built (and stored under the new commit's ID, so later projects reused it from the store), read for its dependencies, and copied by miso vendor. The folder name now ends with the first 16 hex digits of the tarball's sha256. Checked with a test program and two tarballs of miso-1.14.0.0 with different contents (commit X, then commit Y, as after an upgrade): before, both gave commit X's source; now the second gives commit Y's.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug: the source of a library that comes with the tool (and the release's miso) was unpacked in
$MISO_HOME/src/bundled/mhs-VERSION/NAME-VERSION, and reused whenever that folder existed. Butsrc/survives an upgrade, and a new release can ship different source for the same version: miso at another commit, still 1.14.0.0. After such an upgrade, the old source was:miso vendor.The fix: the folder name now ends with the first 16 hex digits of the tarball's sha256.
Checked with a test program and two
miso-1.14.0.0tarballs with different contents (commit X, then commit Y, as after an upgrade):Generated by Claude Code