Repository navigation
Fix fixity issue when catching exceptions when handling .hie files - #5178
Merged
crtschin merged 1 commit intoNov 16, 2026
Merged
Conversation
crtschin
marked this pull request as ready for review
November 15, 2026 00:19
crtschin
force-pushed
the
crtschin/handle-generation-errors-fixity
branch
from
November 16, 2026 09:31
3a4e5e5 to
8c715b0
Compare
crtschin
enabled auto-merge (squash)
November 16, 2026 09:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the flaky CI failure on Windows. Precedence meant that the handler only wrapped the
pure []like so.Which meant that interface file writes could cause the rule to fail despite the handlers. Fixing the parentheses fixes the CI failures, succeeding 40/40 times, where it previously failed 18/40.
CI failure logs