Skip to content

setup cabal audit - #5180

Open
lambdajon wants to merge 1 commit into
haskell:masterfrom
lambdajon:cabal-audit
Open

lambdajon wants to merge 1 commit into
haskell:masterfrom
lambdajon:cabal-audit

Conversation

@lambdajon

Copy link
Copy Markdown

Closes #5174

Open questions

  • I have pinned a specific GHC version; should it support the versions listed in the supported-ghc-versions.json matrix?

  • I read and followed our AI policy
  • I proposed a solution draft in the corresponding issue (for non-trivial changes and new features)
    • This is especially encouraged for new contributors

@fendor
fendor requested a review from MangoIV November 16, 2026 09:53
@fendor

fendor commented Nov 16, 2026

Copy link
Copy Markdown
Collaborator

Thank you for the contribution!

I have pinned a specific GHC version; should it support the versions listed in the supported-ghc-versions.json matrix?

I think we should most likely run it for all supported ghc versions, since the build plans can be vastly different 🤔

cc @MangoIV, is this the best way to run cabal audit in CI? Or should we prefer the nix instructions?

@lambdajon

Copy link
Copy Markdown
Author

@fendor Thanks for the reply! I had also considered using Nix, but I settled on this solution as a proof of concept. However, I wasn't sure how to integrate the generation of SARIF reports if I were to use Nix.

BTW, I will add all supported ghc versions.

@MangoIV

MangoIV commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

I can't make any promises on the action continuing to work of course, but I trust Gautier, so yes, probably the best way :)

@lambdajon
lambdajon marked this pull request as ready for review November 17, 2026 05:20
@fendor

fendor commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

@lambdajon Are you still planning to do the supported ghc version matrix?

@lambdajon

Copy link
Copy Markdown
Author

@fendor Yes, I can do it. Since @MangoIV specifically approved this, I was waiting for your decision.

@fendor

fendor commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

Ah sorry, so, that means we will merge once you have added the supported ghc versions :)

@lambdajon

Copy link
Copy Markdown
Author

Ah sorry, so, that means we will merge once you have added the supported ghc versions :)

Thanks for the answer! I will try to get it done as soon as possible!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use cabal audit to scan for vulnerabilities in the Haskell dependencies

3 participants