Skip to content

lsp.cabal.executable: move build-depends into "if flag(demo)" - #647

Open
thielema wants to merge 1 commit into
haskell:masterfrom
thielema:build-depends-conditional
Open

thielema wants to merge 1 commit into
haskell:masterfrom
thielema:build-depends-conditional

Conversation

@thielema

Copy link
Copy Markdown

This way dependencies are only activated if you enable building the demo executables.

This way dependencies are only activated if you enable building the demo executables.
@fendor

fendor commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator

Are dependencies from unbuildable components included in the install plan?

@thielema

thielema commented Oct 15, 2026 via email

Copy link
Copy Markdown
Author

@fendor

fendor commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator

Right, but buildable: False should remove the component from the install-plan so it should be the same as not having the dependencies, so I am unsure what this PR achieves in particular?

If there is a cabal bug, causing the dependencies to be included in the install plan, I think an issue should be opened in cabal before we merge this kind of refactoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants