Skip to content

chore: split the compile-check changed-files check file under the line limit - #3319

Merged
hatayama merged 1 commit into
feature/compile-check-changed-files-checkfrom
refactor/compile-check-split-baseline-record
Oct 14, 2026
Merged

hatayama merged 1 commit into
feature/compile-check-changed-files-checkfrom
refactor/compile-check-split-baseline-record

Conversation

@hatayama

@hatayama hatayama commented Oct 14, 2026 •

Copy link
Copy Markdown
Owner

Summary

User Impact

  • None. The pull request into main failed build-cli, Go CLI Security Analysis, and test-windows-installers on TestProductionGoFilesStayFocused, because fast_path.go had 575 lines against the architecture test's limit of 500 (it counts every line, unlike the SLOC-based file-length check).

Changes

  • The baseline record types and the code that records a baseline after a full compile (RecordBaseline, the generator output hashing, baselineFiles, writeBaselineRecord, and the path helpers) move unchanged to baseline_record.go, next to baseline_record_test.go. The check that reads a baseline stays in fast_path.go (now 401 lines).

Verification

  • cli/release-automation: go test ./... passes, including TestProductionGoFilesStayFocused, which failed before.
  • cli/dispatcher: go vet ./..., golangci-lint fmt --diff, golangci-lint run (0 issues), the complexity config (0 issues), and go test ./... all pass.
  • File length check: no file over the limit.

View guided diff

fast_path.go had grown to 575 lines, over the 500-line limit the
architecture test enforces. The baseline record types and everything
that writes a baseline after a full compile move to baseline_record.go,
next to the tests that already cover them; the check that reads a
baseline stays in fast_path.go.
@coderabbitai

coderabbitai Bot commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository: hatayama/unity-cli-loop/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 47845ebd-70f6-4432-a10d-bab446ef9bbb
📥 Commits

Reviewing files that changed from the base of the PR and between 4ced3f2 and 402c3b1.

📒 Files selected for processing: 2
  • cli/dispatcher/internal/compilecheck/baseline_record.go
  • cli/dispatcher/internal/compilecheck/fast_path.go
 _______________________________________
< 💖 Git blame less, Git forgive more 🤝. >
 ---------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hatayama
hatayama merged commit 99eff0d into feature/compile-check-changed-files-check Oct 14, 2026
2 of 4 checks passed
@hatayama
hatayama deleted the refactor/compile-check-split-baseline-record branch October 14, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant