Repository navigation
chore: split the compile-check changed-files check file under the line limit - #3319
Merged
hatayama merged 1 commit intoOct 14, 2026
Conversation
fast_path.go had grown to 575 lines, over the 500-line limit the architecture test enforces. The baseline record types and everything that writes a baseline after a full compile move to baseline_record.go, next to the tests that already cover them; the check that reads a baseline stays in fast_path.go.
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 2
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hatayama
merged commit Oct 14, 2026
99eff0d
into
feature/compile-check-changed-files-check
2 of 4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fast_path.goso the final pull request intomain(feat: compile-check answers a method-body edit in a large assembly in seconds instead of a full recompile #3318) passes CI.User Impact
mainfailedbuild-cli,Go CLI Security Analysis, andtest-windows-installersonTestProductionGoFilesStayFocused, becausefast_path.gohad 575 lines against the architecture test's limit of 500 (it counts every line, unlike the SLOC-based file-length check).Changes
RecordBaseline, the generator output hashing,baselineFiles,writeBaselineRecord, and the path helpers) move unchanged tobaseline_record.go, next tobaseline_record_test.go. The check that reads a baseline stays infast_path.go(now 401 lines).Verification
cli/release-automation:go test ./...passes, includingTestProductionGoFilesStayFocused, which failed before.cli/dispatcher:go vet ./...,golangci-lint fmt --diff,golangci-lint run(0 issues), the complexity config (0 issues), andgo test ./...all pass.