Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions apps/server/src/ws.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1337,6 +1337,8 @@ const layerWsRpc = () =>
{ concurrency: "unbounded", discard: true },
);
}
// Coder: host credentials hold no secret references (#27746), so a secret reload has
// no host-secret cache to invalidate.
const providers = yield* input.cwd !== undefined && input.instanceId !== undefined
? providerRegistry.refreshWorkspaceSnapshot({
instanceId: input.instanceId,
Expand Down
26 changes: 17 additions & 9 deletions docs/internals/coder-only.md
Original file line number Diff line number Diff line change
Expand Up @@ -275,9 +275,9 @@ fails on any non-loopback URL literal, `fetch(`, outbound `node:net`/`tls`/`http
process import other than `spawn`, spawn target other than an invocation's executable, executable
literal other than `coder`, `open`, `xdg-open`, or `explorer.exe`, or `shell: true`.

Provider version checks are workspace-originated network requests: the helper queries
`registry.npmjs.org` for the latest version of each enabled provider whose installer it can
identify; manual installations are not checked. The workspace setting `enableProviderUpdateChecks`
Provider version checks are workspace-originated network requests: the helper asks the
workspace's own `npm view` (its configured registry, #27847) and otherwise `registry.npmjs.org`
for the latest version of each enabled provider whose installer it can identify; manual installations are not checked. The workspace setting `enableProviderUpdateChecks`
is on by default; disabling **Settings → Maintenance → Provider update checks** opts that workspace
out. Explicit provider updates run the installation's identified installer inside the workspace.
Versions marked broken or unsupported by the bundled compatibility policy are not offered. The
Expand Down Expand Up @@ -551,7 +551,8 @@ listed here is drift to remove rather than fork behavior to keep.
`orchestration_error` so a running task resumes once the switch is on again; `T3ToolBridge`'s binding gains `invoke` for a
linked caller; and upstream's peer tests (`PeerForwarding.test.ts`, `RemoteDelegation.test.ts`,
`linkOrigin.test.ts`, `PeerLinks.testkit.ts`) are not carried because they pair two HTTP
servers; `coderHub.test.ts` and the gateway's `hub.test.ts` test the transport. Migrations 070
servers, nor is `PeerMcpClient.test.ts` (#26567's HTTP MCP session reuse; hub calls hold no
session); `coderHub.test.ts` and the gateway's `hub.test.ts` test the transport. Migrations 070
and 071 keep their IDs and create nothing; 072's index stays. `peerLinks` and `linkFence` are
advertised; `mcpModeLimitHeader` is in `CODER_OMITTED_CAPABILITIES`. Remote-task lineage from
`remoteChild` and `delegatedFrom` (the task row, the delegated thread's parent link and "From"
Expand Down Expand Up @@ -1227,7 +1228,7 @@ listed here is drift to remove rather than fork behavior to keep.
`canonicalizeGitCafePullRequestUrl` is an identity function, since GitCafe is not carried. Diff output is capped
(`DIFF_MAX_OUTPUT_BYTES`) to fit the gateway's `MAX_RPC_MESSAGE_BYTES` ceiling.
- GitLab fixes for bugs still in upstream's `GitLabCli` (checked against upstream `main`
32ecd71726):
80a2351fcb):
merge requests between projects post to the source project with a numeric
`target_project_id` instead of sending the repository text as `source_project_id`; merge
request URLs reach `glab` as `--repo <url> ... -- <iid>` because older versions read URLs as
Expand Down Expand Up @@ -1493,7 +1494,7 @@ listed here is drift to remove rather than fork behavior to keep.
kinds to the fork's typed project helper. Shared `AgentScope.ts` leaves out upstream's
`agentScopeLauncherScript` (#27239), which only the uncarried preview browser launches, and
`AgentScope.test.ts` drops its launcher check.
`ThreadDetailsPrRows.browser.test.tsx` checks the run context, not the editor picker. `CommandPalette.browser.test.tsx`
`CommandPalette.browser.test.tsx`
mocks `useCoder`, and `GitLabPullRequestCli.legacy.test.ts` expects the fork's `DIFF_MAX_OUTPUT_BYTES`.
`SourceControlProviderRegistry.test.ts` is upstream's fake-driver file, with its unknown-host
fallback on a GitLab remote and a GitHub URL among the URLs no host claims.
Expand All @@ -1517,8 +1518,7 @@ listed here is drift to remove rather than fork behavior to keep.
over the helper's history RPC (`threadHistoryHttp.ts`) instead of upstream's HTTP client.
`ws.test.ts` omits upstream's config-RPC buffering test, which builds upstream's session-scoped
`layerWsRpc`. Upstream's `composerContextUndo.test.ts` (preview annotations
only) is not carried; `DiffPanel.browser.test.tsx` passes `onOpenFile` without an editor mock,
and `ProjectSettingsPanel.browser.test.tsx` keeps `projects.getConfig` pending as upstream
only) is not carried, and `ProjectSettingsPanel.browser.test.tsx` keeps `projects.getConfig` pending as upstream
keeps its file read.
`pullRequestsRouteSearch.test.ts` runs under happy-dom, because the route module loads the diff
worker, which needs a browser `self`. Upstream's `*.browser.test.*` files run in headless
Expand All @@ -1530,7 +1530,15 @@ listed here is drift to remove rather than fork behavior to keep.
`ChatMarkdown.permissions.browser` tests are not carried), `ProjectSettingsPanel.test.tsx`, and `RightPanelTabs.test.tsx`
(upstream's `RightPanelTabs.browser.test.tsx` is not carried). The carried browser tests omit
cases for cut surfaces: grant checks in `ProjectSettingsPanel`, uncarried providers in
`ProviderModelPicker`, and preview mocks in `ReopenClosedViewShortcut`.
`ProviderModelPicker.composition`, and preview mocks in `ReopenClosedViewShortcut`. Upstream's
`ProviderModelPicker.browser.test.tsx` (ACP Registry icon cache) and `ChatView.browser.test.tsx`
(`test/fakeEnvironment`) are not carried. Each marked: `CommandPalette.composition` mocks
`useCoder` and picks the workspace first; `StorageSettings` keys its status mock on the
saved-image-artifacts title; `useComposerContextImport` drops linked environments, composer
images, and annotation cases; `useComposerResume` and `useThreadLifecycle` pass no
`clearUsageLimitsFor`; `FilePreviewPanel` has no remote-open mock or editor props;
`PullRequestMarkdown` runs on the GitLab-only registry with `repositoryUrl`; and
`ProviderSettingsForm.test.ts` has no secret-source cases.
- **Omitted surfaces.** Desktop, mobile, hosted web, browser preview, telemetry, OTLP and trace
export, the diagnostics page, usage dashboards, and hosted providers other than GitLab. Without
browser preview, `composerDraftStore.ts` does not keep an empty draft alive for an open page,
Expand Down
2 changes: 2 additions & 0 deletions packages/client-runtime/src/connection/registry.ts
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,8 @@ export const make = Effect.gen(function* () {
),
);

// Coder: every reconcile is applied (no #26511 skip of unchanged registrations), since it also
// re-acquires each workspace's supervisor.
const reconcilePlatform = Effect.fn("EnvironmentRegistry.reconcilePlatform")(function* (
registrations: ReadonlyArray<PlatformConnectionRegistration>,
) {
Expand Down
11 changes: 9 additions & 2 deletions scripts/sync-resolve-deleted.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -198,10 +198,11 @@ const DELETED_PATHS = {
// Upstream tests built on cut surfaces: the fake environment harness, upstream's HTTP peer
// MCP client, and host credential secret references.
"apps/web/src/components/ChatView.browser.test.tsx",
// Upstream's ACP Registry icon cache (`settings/AcpRegistryIcon.tsx`), which Kilo Code's inlined icon replaces.
"apps/web/src/components/chat/ProviderModelPicker.browser.test.tsx",
"apps/server/src/peer/PeerMcpClient.test.ts",
"apps/server/src/sourceControl/sourceControlHostSecrets.test.ts",
// Upstream's ACP Registry icon cache (`settings/AcpRegistryIcon.tsx`), which Kilo Code's
// inlined icon replaces.
"apps/web/src/components/chat/ProviderModelPicker.browser.test.tsx",
"apps/web/src/components/settings/ProviderSettingsPanel.environment.browser.test.tsx",
"apps/web/src/components/settings/ThemeImportDialog.browser.test.tsx",
"apps/server/src/mcp/toolkits/core.test.ts",
Expand Down Expand Up @@ -344,6 +345,12 @@ const DELETED_PATHS = {
"packages/secret-provider-definitions/",
"packages/secret-provider-onepassword/",
],
// Other cut web surfaces: the GitHub star prompt (#27832; GitLab is the only host) and guests'
// screenshot URLs (#26323; workspace images load through the workspace asset route).
"other web surfaces": [
"apps/web/src/components/GitHubStarPrompt.tsx",
"apps/web/src/components/chat/hostImageUrl.ts",
],
// Upstream repository tooling: vendored sources, CI, hooks, editor and agent configuration,
// and operations docs. The fork's .github/ keeps only SECURITY.md.
"upstream repository tooling": [
Expand Down