Verify organization 2FA and SSO requirements before fetching - #1237
Open
ericmj wants to merge 2 commits into
Open
Verify organization 2FA and SSO requirements before fetching#1237ericmj wants to merge 2 commits into
ericmj wants to merge 2 commits into
Conversation
This was referenced Sep 9, 2026
ericmj
commented
Sep 10, 2026
| HEXPM_OTP: OTP-28.5 | ||
| HEXPM_ELIXIR: v1.19.5 | ||
| HEXPM_BRANCH: main | ||
| HEXPM_BRANCH: organization-tfa-enforcement |
Member
Author
There was a problem hiding this comment.
This needs reverting back to main before merging.
ericmj
marked this pull request as ready for review
September 10, 2026 02:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When private dependencies require renewed organization authentication, Hex names the affected organizations and displays separate 2FA and SSO requirements. The shared browser verification flow refreshes scopes afterward and preserves outstanding requirements when authentication is cancelled, expires, or receives EOF.
Vendor the corresponding hex_core protocol changes and add integration coverage against Hexpm for organization scope filtering, verification requests, and OTP restoration. The full Hex suite against the changed server passed 661 tests with one existing skip; formatting passed.
Depends on hexpm/hex_core#222, vendored from hexpm/hex_core@b3757c5.
Related drafts: hexpm/hexpm#1913, hexpm/hex_core#222, #1237, https://github.com/hexpm/hexpm-ops/pull/325.
Draft CI runs against the
organization-tfa-enforcementserver branch from hexpm/hexpm#1913. RestoreHEXPM_BRANCH: mainafter that server change merges and before merging this PR.Staging validation passed with the changed server, Hex client and Fastly services: real Chrome TOTP and private-documentation return, existing-cookie renewal, sign-in after browser revocation, cancellation, expired/mismatched/revoked requests, and CLI reauthorization followed by a cold private-package fetch, compilation and execution. The CLI also refused noninteractive/declined verification and retained control-organization access. Session expiry and copied proof timestamps were checked, including source-browser revocation. Desktop (1440px) and mobile-width (375px) screenshots were inspected.
The staging fixture uses synthetic accounts and complimentary billing. Verification ages were changed only on fixture sessions. Live SSO-provider authentication, enrollment, email delivery and billing-provider behavior weren't exercised in staging.