Repository navigation
Fix exact URL indicator matching in Security Analysis - #12
Draft
hideouts-io wants to merge 1 commit into
Draft
hideouts-io wants to merge 1 commit into
hideouts-io wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Native Security Analysis treated a lowercase URL substring as an exact IOC match. A longer host, path, or query could therefore produce a false exact finding, and a normalized match could export the indicator spelling instead of the URL observed in evidence.
Change
Verification
nice -n 10 swift test -j 4 -Xswiftc -warnings-as-errors --filter SecurityAnalysisTests --quiet: 13 passed.nice -n 10 swift build -j 4 -Xswiftc -warnings-as-errors --quiet: passed.nice -n 10 swift test -j 4 -Xswiftc -warnings-as-errors --quiet: 267 passed.nice -n 10 xcodebuild -project iOSDeveloperToolkit.xcodeproj -scheme iOSDeveloperToolkit -destination 'platform=macOS' -derivedDataPath /tmp/idt-url-equality-20261023-derived -jobs 4 build -quiet: passed. The app target retains warnings as errors.SWIFT_TREAT_WARNINGS_AS_ERRORS=YESoverride was attempted and interrupted by incompatible-warnings-as-errors/-suppress-warningsoptions in the third-party SwiftNIO_NIOBase64and_NIODataStructurestargets.Hosted CI and Swift CodeQL for this candidate are pending. No native UI or physical-device workflow was exercised; the changed behavior is the local scanner and its report output. Ambiguous adjacent URL punctuation is retained, so the matcher may conservatively miss such text rather than label a different URL exact.