Repository navigation
fix: code scanning #340–#346 (missed-where/select, a constant condition) - #288
Merged
Merged
Conversation
- #346 cs/constant-condition (BoardTaskService): test the repo for null before the helper instead of after it. - #340/#341/#343 cs/linq/missed-where: Select/OfType/Where (AgentsOptions.All, the agent registry guard test, TicketFlowValidator's edge check). - #342/#344 cs/linq/missed-where with an awaited condition: skip explicitly with continue (a Where can't await). - #345 cs/linq/missed-select: Select(TicketStepKinds.Of). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018WAdQ7Rm24xss5QDSvXtJB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clears the 7 open code-scanning alerts that came in with #278, #285 and #286. All are code quality; none is a vulnerability.
cs/constant-condition(BoardTaskService.cs:555): checkstoodfor null before callingFailedFollowUpKeepsItsChange.cs/linq/missed-where: useSelect/OfType/WhereinAgentsOptions.All,AgentRegistryGuardTestsandTicketFlowValidator's edge check.cs/linq/missed-wherewhere the condition awaits: skip with an explicitcontinue, since aWherecan't await.cs/linq/missed-select:Select(TicketStepKinds.Of).Test plan
dotnet test --solution AgentOs.slnx -c Release: 1,770 passed, 0 failed.🤖 Generated with Claude Code
https://claude.ai/code/session_018WAdQ7Rm24xss5QDSvXtJB