Skip to content

Fix countdown alignment in compact Dynamic Island - #6080

Open
kmishukov wants to merge 2 commits into
home-assistant:mainfrom
kmishukov:fix/5910-island-spacing
Open

kmishukov wants to merge 2 commits into
home-assistant:mainfrom
kmishukov:fix/5910-island-spacing

Conversation

@kmishukov

Copy link
Copy Markdown

AI Policy

Select exactly one option that describes AI usage in this contribution:

  • I have not used AI for this contribution.
  • AI assistance was used for this contribution.
  • AI fully generated the code for this contribution, but I've reviewed and understood it before submitting and will respond without AI during review.

Summary

Fixes #5910.

Align the countdown text to the trailing edge of its fixed-width frame in the compact Dynamic Island. This removes the excess space to the right of short countdowns while preserving the existing width, text scaling, and seconds display.

Screenshots

Before:
IMG_5704

After:
IMG_5706

Link to pull request in Documentation repository

Not applicable.

Any other notes

Tested on iPhone 16 Pro Max.

Copilot AI balanced review requested due to automatic review settings October 16, 2026 03:48

@home-assistant home-assistant Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kmishukov

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
home-assistant Bot marked this pull request as draft October 16, 2026 03:48
@home-assistant

Copy link
Copy Markdown

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Affected snapshot references need updating to match the intended alignment.

1 open finding
What changed in this PR

Fixes #5910 by right-aligning the Live Activity countdown in the compact Dynamic Island.

Changes:

  • Adds trailing text alignment while preserving timer width, scaling, and seconds display.
File Description
Sources/​Extensions/​Widgets/​LiveActivity/​HACompactTrailingView.swift Aligns compact countdown text to the trailing edge.

🧠 Review effort: Balanced


💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread Sources/Extensions/Widgets/LiveActivity/HACompactTrailingView.swift

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The isolated alignment change has no identified blocking issues, with physical-device verification and passing snapshots reported.

0 open findings

1 resolved since last review

🧠 Review effort: Balanced

@kmishukov
kmishukov marked this pull request as ready for review October 16, 2026 04:10
@bgoncal
bgoncal enabled auto-merge (squash) October 16, 2026 08:41
@kmishukov

kmishukov commented Oct 16, 2026 •

Copy link
Copy Markdown
Author

Hi @bgoncal,

The CI test job timed out. Could you take a look and rerun it when you have a chance? I ran the tests locally, and they all passed.

upd. merged 'main' just in case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Live Activity countdown has uneven spacing in the compact Dynamic Island

3 participants