fix(infra): scope the infrastructure lock key by deployment id - #1065
Open
alexluong wants to merge 1 commit into
Open
fix(infra): scope the infrastructure lock key by deployment id#1065alexluong wants to merge 1 commit into
alexluong wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WSUm1ZBeUurupWpGWwE8NM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The infrastructure declaration lock always used the Redis key
outpost:lock. Deployments that share a Redis instance viaDEPLOYMENT_IDtherefore contended on one global lock and could fail startup withfailed to acquire lock after 5 attemptswhen several declared at the same time. The key is now<DEPLOYMENT_ID>:outpost:lock, matching the prefix used for the other deployment-scoped keys; it staysoutpost:lockwhenDEPLOYMENT_IDis unset.Testing:
go build ./...,go vet,go test -short ./internal/infra/... ./internal/app/...pass; addedTestLockKey.🤖 Generated with Claude Code
https://claude.ai/code/session_01WSUm1ZBeUurupWpGWwE8NM