fix(gcppubsub): create subscriptions that never expire - #1066
Open
alexluong wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WSUm1ZBeUurupWpGWwE8NM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pub/Sub applies a default expiration policy that deletes a subscription after 31 days without subscriber activity. The dead-letter subscription has no consumer, so it expires and dead-lettered messages are dropped until the next
Declarerecreates it. This setsExpirationPolicyto never on both the main and dead-letter subscriptions.Testing:
go build ./...,go vet ./internal/mqinfra/...,go test -short ./internal/mqinfra/...; newTestIntegrationMQInfra_GCPPubSub_SubscriptionsNeverExpirepasses against the emulator and fails without the fix.🤖 Generated with Claude Code
https://claude.ai/code/session_01WSUm1ZBeUurupWpGWwE8NM