Skip to content

fix(ci): resolve lint and Helm fixture security failures - #915

Merged
neilime merged 1 commit into
mainfrom
fix/ci-lint-failures
Sep 28, 2026
Merged

neilime merged 1 commit into
mainfrom
fix/ci-lint-failures

Conversation

@neilime

@neilime neilime commented Sep 28, 2026

Copy link
Copy Markdown
Member

The newer Super-linter reports failures on generated assets, duplicated fixture/documentation content, the documentation app token, and the umbrella chart's Valkey defaults. Update the lint configuration and Helm values so the checks pass without the Docker build-token breaking change being part of this diff.

  • Update the local linter image and documentation action lockfile, exclude the two oversized SVG assets from Biome, and exclude generated documentation, lockfiles, and test workflows from duplication checks while retaining the 5% threshold.
  • Limit the documentation app token to its required contents and pull-request write permissions.
  • Use Valkey's supported security/resource settings for both application and init containers, pin its image digest, and enable a readiness probe and a network policy.
  • Replace the obsolete Trivy exceptions with the namespace exception, and baseline only the four upstream Valkey namespace findings in Checkov. Other namespace and resource checks remain enabled.

Stacked on #914: merge that breaking-change PR first, then retarget this PR to main. The diff here contains only the remaining nine lint-fix files.

Validation: make ci and strict Helm lint pass in a clean checkout with locked chart dependencies installed; validation leaves the checkout unchanged. Rendered-manifest checks verified the Valkey settings, and negative controls confirmed other namespace violations and Valkey resource-limit violations still fail security checks.

@neilime
neilime changed the base branch from fix/restrict-build-github-app-token to main September 28, 2026 19:08
@neilime
neilime force-pushed the fix/ci-lint-failures branch from ee9a4c9 to 57dfec1 Compare September 28, 2026 19:10
Signed-off-by: Emilien Escalle <emilien.escalle@escemi.com>
@neilime
neilime force-pushed the fix/ci-lint-failures branch from 57dfec1 to b3b281f Compare September 28, 2026 19:10
@github-actions

Copy link
Copy Markdown
Contributor

Super-linter summary

Language Validation result
BIOME_FORMAT Pass ✅
BIOME_LINT Pass ✅
CHECKOV Pass ✅
DOCKERFILE_HADOLINT Pass ✅
GITHUB_ACTIONS_ZIZMOR Pass ✅
GITLEAKS Pass ✅
GIT_MERGE_CONFLICT_MARKERS Pass ✅
JSCPD Pass ✅
PRE_COMMIT Pass ✅
SPELL_CODESPELL Pass ✅
TRIVY Pass ✅
YAML Pass ✅
YAML_PRETTIER Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@neilime
neilime merged commit 7120ed3 into main Sep 28, 2026
171 checks passed
@neilime
neilime deleted the fix/ci-lint-failures branch September 28, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant