Repository navigation
Add Safe v1.5.0 canonical addresses - #2
Closed
techdigger wants to merge 2 commits into
Closed
techdigger wants to merge 2 commits into
techdigger wants to merge 2 commits into
Conversation
safe_addresses.py lists contracts up to v1.4.1, so on a chain where only v1.5.0 is deployed the interactive mode fails to find a Safe singleton, fallback handler, proxy factory, MultiSend or SignMessageLib. Add the v1.5.0 canonical addresses (safe-deployments v1.5.0) first in each list.
Listing v1.5.0 first made it the default on every network that has it: safe-creator would create v1.5.0 Safes, update would move old Safes straight to v1.5.0, and v1.4.1 Safes would be reported as not updated. List it last instead, so networks with an earlier version behave as before and networks with only v1.5.0 work. Add a test for both cases, for all seven lists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced by #8: the same code as one commit on a clean branch.