Repository navigation
Humanode: legacy gas price on by default on chain 5234, and CI - #4
Closed
techdigger wants to merge 2 commits into
Closed
techdigger wants to merge 2 commits into
techdigger wants to merge 2 commits into
Conversation
Owners cannot forget the flag. SAFE_CLI_LEGACY_GAS=0 turns it off. Kept in Humanode's fork only; upstream gets the flag alone.
Runs upstream's tests against Ganache as upstream's ci.yml does, builds the wheel and publishes it with a SHA-256 manifest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1, so the diff shows only this PR's two commits. Once #1 is merged and its branch deleted, GitHub retargets this PR to
main.What
--legacy-gas-priceis on without the flag, so owners cannot forget it.SAFE_CLI_LEGACY_GAS=0turns it off, and--legacy-gas-price=<gwei>still sets a price by hand. This commit stays in our fork only and is not proposed upstream..github/workflows/humanode-build.yml), on every pull request and on pushes tomain:ci.ymldoes;Tested
test_default_on_humanode: on by default on chain 5234, off withSAFE_CLI_LEGACY_GAS=0, off on other chains.Generated by Claude Code