Repository navigation
Leave headroom in EIP-1559 fees - #6
Closed
techdigger wants to merge 2 commits into
Closed
techdigger wants to merge 2 commits into
techdigger wants to merge 2 commits into
Conversation
EthereumClient.set_eip1559_fees sets maxFeePerGas to the next block's forecast base fee plus the tip, with no headroom. If the base fee rises before the transaction is included, the cap falls below it and the transaction waits. On chains that charge more than their fee history forecasts (a fixed-fee chain whose node still projects a falling base fee) every transaction is refused. Use 2 x base fee + tip, as ethers, viem and web3.py's default strategy do, for every transaction safe-cli sends. maxFeePerGas is only a cap: the sender still pays the base fee plus the tip.
Cover execution with a local key, approve_hash and execution with a hardware wallet in one test, each against a fee history that forecasts less than the chain charges.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed in favour of #1, which keeps safe-cli's default and adds one option,
--max-fee-per-gas, instead of changing the fee rule for everyone.