Repository navigation
Add --max-fee-per-gas - #7
Closed
techdigger wants to merge 1 commit into
Closed
techdigger wants to merge 1 commit into
techdigger wants to merge 1 commit into
Conversation
safe-cli takes maxFeePerGas from eth_feeHistory and gives the user no way to change it. A chain that charges more than its fee history forecasts refuses each transaction safe-cli sends, and on a busy chain the user may want a higher cap. Add a global option, --max-fee-per-gas GWEI, and its default, SAFE_CLI_MAX_FEE_PER_GAS. It sets maxFeePerGas for each transaction safe-cli sends: execution with a local key, approve_hash and execution with a hardware wallet. Transactions stay EIP-1559 and the tip stays the estimate. Without the option safe-cli behaves as before. safe-cli refuses a cap above 10 times the node's gas price and sends nothing, which catches typos such as extra zeros.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced by #10, which does the same with one environment variable and no command-line flag.