Repository navigation
Sign approve_hash with hardware wallets - #9
Closed
techdigger wants to merge 1 commit into
Closed
techdigger wants to merge 1 commit into
techdigger wants to merge 1 commit into
Conversation
approve_hash calls sender_account.sign_transaction. Local accounts have that method. Ledger and Trezor senders don't, so the call raises AttributeError and a hardware-wallet owner can't approve a Safe transaction hash on chain. Sign with the hardware wallet's get_signed_raw_transaction when the sender has it, as execute_safe_tx does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
approve_hashsigns with the hardware wallet'sget_signed_raw_transactionwhen the sender is a Ledger or Trezor, and withsign_transactionfor a local key.Why
approve_hashcallssender_account.sign_transaction. Local accounts have that method. Ledger and Trezor senders don't, so the call raisesAttributeErrorand a hardware-wallet owner can't approve a Safe transaction hash on chain. On chains without a Safe Transaction Service, owners on separate machines collect signatures throughapprove_hash.Tested
A new test runs
approve_hashwith a sender that hasget_signed_raw_transactionand nosign_transaction, as a hardware wallet does:AttributeError;The change makes the same
get_signed_raw_transaction(tx, chain_id)call thatexecute_safe_txmakes for Ledger and Trezor. I did not run it with a physical device.Generated by Claude Code