Conversation
kjlippold
commented
Sep 23, 2026
kjlippold
commented
Contributor
- Unnested vocabulary endpoints from their parent resource types so they can be included as OGC feature collections.
- Added additional vocabulary management API endpoints (create, update, and delete) for admin use.
- Added optional description field to all vocabulary tables.
- Added vocabularies to include parameter for collection endpoints.
Specifically, this commit fixes breaking signature changes for the Python client where code and name were swapped so existing scripts would have loaded data into the wrong fields. Fixed some frontend display issues, reverted changes to the QC app, and standardized a few missing fields like Method.sensor_model_definition being a CharField, not a URL field like the others
daniel-slaugh
self-requested a review
September 25, 2026 16:18
daniel-slaugh
requested changes
Sep 25, 2026
daniel-slaugh
left a comment
daniel-slaugh
left a comment
Contributor
There was a problem hiding this comment.
Approach looks good to me. Everything seems to be working except one blocker the agents picked up:
Blank descriptions fail the new API contract.
Vocabulary schema, line 21
POST and PATCH reject description: "" because the inherited validator converts it to None, which the str field rejects. This affects all eight vocabularies and result qualifiers: default TypeScript objects cannot be created with blank descriptions, and an existing description cannot be cleared with an empty string.
The fix must preserve empty strings through validation in both vocabulary and qualifier request schemas. Also align the Python client’s omitted-description behavior: it currently sends null, which fails too.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.