Conversation
|
@JM00NJ could you add the sign-off line to the commits message? The DCO check is failing. Thanks! |
5aef1a5 to
ade6b88
Compare
|
Hey @JM00NJ, thanks for the fixes! I just wanted to give you a heads-up about the stack communication, that it will be soon replaced by virtual queue based comms. This means that, unfortunately, the changes from this PR and |
Thanks for the heads up! Good to know about the virtual queue migration. I'll take a look at #1794 ; happy to contribute there once the new implementation lands. |
|
Also, the commit also needs to be GPG signed, I'm happy to merge it after you sign it, even if this code is going away. |
Signed-off-by: JM00NJ <51642194+JM00NJ@users.noreply.github.com>
Head branch was pushed to by a user without write access
ade6b88 to
ff21631
Compare
Follow-up to #1820.
Replaces
as u64cast with.try_into()inpush_bufferfor correctness and future-proofing, as suggested by @jprendes. Whileusize == u64on both x86_64 and ARM64 currently,.try_into()makes the conversion explicit and safe for any future platform changes.