Repository navigation
Fix trade websocket payload types - #328
Open
koriyoshi2041 wants to merge 1 commit into
Open
koriyoshi2041 wants to merge 1 commit into
koriyoshi2041 wants to merge 1 commit into
Conversation
koriyoshi2041
force-pushed
the
fix/trade-wire-types
branch
from
October 21, 2026 05:02
a632a77 to
2622e5d
Compare
Author
|
I rechecked the public Observed payload shape for BTC: Because Python's JSON decoder preserves the wire array as a Revalidated with mypy, Black, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #327.
The live
tradeswebsocket payload representsszas a string, includes an integertid, and includesusersas a two-element JSON array. This updates the PythonTradeTypedDict to match the values produced by Python's JSON decoder:sz: strtid: intusers: List[str]The official Rust SDK models the same wire fields as
String,u64, and(String, String). The Python annotation intentionally usesList[str]rather than copying the Rust tuple becausejson.loadspreserves the wire array as a Python list.Validation:
tradeswebsocket payload inspectionuvx mypy hyperliquid/utils/types.pyuvx black --check hyperliquid/utils/types.pypython -m compileall -q hyperliquid/utils/types.pygit diff --check