test(oracle): avoid secret-scanner fixture false positive - #119
hyperpolymath wants to merge 3 commits into
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 37502491 | Triggered | Generic Password | d33ab22 | src/oracle/src/lib.rs | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
Warning Review limit reachedNext included review available in 46 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Superseded by a clean-base PR because GitGuardian continued to attribute the already-merged fixture literal to the old commit history. The corrected fixture is now isolated in PR #120. |
The hardening changes from PR #118 were merged, but the new directory-scan regression fixture is intentionally assembled at runtime and needs to be merged separately because the first PR was merged before this follow-up commit reached the branch.
This keeps the test behavior intact while preventing GitGuardian from classifying the fixture literal as a generic password. The policy oracle test suite passes locally.