Skip to content

test(oracle): avoid secret-scanner fixture false positive - #119

Closed
hyperpolymath wants to merge 3 commits into
mainfrom
agent/harden-scan-and-fail-closed
Closed

hyperpolymath wants to merge 3 commits into
mainfrom
agent/harden-scan-and-fail-closed

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

The hardening changes from PR #118 were merged, but the new directory-scan regression fixture is intentionally assembled at runtime and needs to be merged separately because the first PR was merged before this follow-up commit reached the branch.

This keeps the test behavior intact while preventing GitGuardian from classifying the fixture literal as a generic password. The policy oracle test suite passes locally.

@gitguardian

gitguardian Bot commented Sep 21, 2026

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
37502491 Triggered Generic Password d33ab22 src/oracle/src/lib.rs View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 46 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 9dd8a837-488e-40c6-97f5-6e92d466788d

📥 Commits

Reviewing files that changed from the base of the PR and between 08d42c8 and 81922c8.

📒 Files selected for processing (3)
  • src/main.rs
  • src/oracle/src/lib.rs
  • src/slm/src/lib.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hyperpolymath

Copy link
Copy Markdown
Owner Author

Superseded by a clean-base PR because GitGuardian continued to attribute the already-merged fixture literal to the old commit history. The corrected fixture is now isolated in PR #120.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant