Skip to content

chore(ci): repoint push-email-notify to smtp-notify-action - #63

Merged
hyperpolymath merged 1 commit into
mainfrom
chore/smtp-notify-action
Sep 3, 2026
Merged

chore(ci): repoint push-email-notify to smtp-notify-action#63
hyperpolymath merged 1 commit into
mainfrom
chore/smtp-notify-action

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Replaces dawidd6/action-send-mail with hyperpolymath/smtp-notify-action v0.2.0 (tag commit ede1191ef6ff3ac02c4f4d9efdf837ee517e11d7), per the 2026-09-02 ruling (standards spec §5.5/§9, PR hyperpolymath/standards#725). The whole file is replaced with the rsr-template-repo canonical, which — besides the uses: line — restricts the trigger to branch pushes (tag and deletion payloads mislabel Branch:/head_commit), sets timeout-minutes: 5, carries a deliberately per-run concurrency group, and grants only contents: read. How many of those are actual changes here depends on how far this repo's copy had drifted — read the diff, not this list. Dormant gating on vars.PUSH_EMAIL_ENABLED == 'true' is unchanged. Line 1 SPDX header kept as it was.

Engine: .git-private-farm/scripts/smtp-notify-sweep.sh. Verification for this repo: regime=no-lock changed=.github/workflows/push-email-notify.yml, sig=G f6ac064 canon=543fc1474b54 base=main
(pristine/post = gh actions-lock --no-fix validity before/after; repair = the lock was already invalid before this change and is valid after it.)

🤖 Generated with Claude Code

Replaces dawidd6/action-send-mail with hyperpolymath/smtp-notify-action v0.2.0 (ede1191ef6ff3ac02c4f4d9efdf837ee517e11d7) per the 2026-09-02 ruling; file is the rsr-template-repo canonical (dormant gating on vars.PUSH_EMAIL_ENABLED unchanged). regime=no-lock changed=.github/workflows/push-email-notify.yml,

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@sonarqubecloud

sonarqubecloud Bot commented Sep 3, 2026

Copy link
Copy Markdown

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: f399fd21-7fc6-4c2e-be09-087a44a82136

📥 Commits

Reviewing files that changed from the base of the PR and between b85dc6a and f6ac064.

📒 Files selected for processing (1)
  • .github/workflows/push-email-notify.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (25)
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: governance / Trusted-base reduction policy
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: governance / Licence consistency
  • GitHub Check: governance / Well-Known (RFC 9116 + RSR)
  • GitHub Check: governance / Guix primary / Nix fallback policy
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: governance / Security policy checks
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: rust-ci / Detect Cargo.toml
  • GitHub Check: scan / Hypatia Neurosymbolic Analysis
  • GitHub Check: scan / gitleaks
  • GitHub Check: scan / rust-secrets
  • GitHub Check: scan / shell-secrets
  • GitHub Check: panic-attack assail
  • GitHub Check: Hypatia neurosymbolic scan
  • GitHub Check: Zig FFI builds + tests (Zig 0.14.0)
  • GitHub Check: ABI ↔ FFI structural conformance
  • GitHub Check: analyze (actions, none)
  • GitHub Check: validate
  • GitHub Check: Validate A2ML manifests
  • GitHub Check: Validate eclexiaiser manifest
  • GitHub Check: Groove manifest check
  • GitHub Check: Validate K9 contracts
  • GitHub Check: Empty-linter (invisible characters)
🔇 Additional comments (1)
.github/workflows/push-email-notify.yml (1)

6-10: LGTM!

Also applies to: 13-15, 16-31, 39-42


📝 Summary

Summary by CodeRabbit

  • Changes
    • Push email notifications now respond only to branch pushes.
    • Notifications are processed independently for each workflow run, without cancelling earlier runs.
    • Email delivery workflows now have a five-minute execution limit.
    • Notifications remain inactive unless the PUSH_EMAIL_ENABLED setting is enabled.

Walkthrough

The push-email workflow now runs for branch pushes only. Each run has its own concurrency group and a five-minute timeout. The workflow uses a SHA-256-pinned SMTP notification action and remains gated by PUSH_EMAIL_ENABLED.

Changes

Push email notifications

Layer / File(s) Summary
Branch push filtering
.github/workflows/push-email-notify.yml
The workflow trigger now accepts branch pushes only.
Notification execution controls
.github/workflows/push-email-notify.yml
The workflow adds per-run concurrency, a five-minute timeout, and the pinned hyperpolymath/smtp-notify-action action. Comments document the re-land and action properties.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to f6ac0

The push-email workflow now uses the pinned SMTP action with branch-only triggering, timeout, and notification-preserving concurrency controls. No merge-blocking risk remains.

Poem

A rabbit checks the branch at dawn
Each run hops on, none are withdrawn
Five minutes guards the SMTP trail
A pinned action carries mail
The workflow thumps its paws: success

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the action replacement and lists the workflow changes. However, it omits the required RSR Quality Checklist and does not use the template's Summary, Changes, and Testing secti… Add the required template sections. Complete the RSR Quality Checklist, including applicable items, and add a Testing section with the exact validation commands and results. State whether screenshots are not applicable, if required by repos…
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: replacing the push-email workflow's mail action.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the action replacement and lists the workflow changes. However, it omits the required RSR Quality Checklist and does not use the template's Summary, Changes, and Testing sections. The verification details do not clearly state the test or validation commands performed.

Resolution

Add the required template sections. Complete the RSR Quality Checklist, including applicable items, and add a Testing section with the exact validation commands and results. State whether screenshots are not applicable, if required by repository practice.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hyperpolymath
hyperpolymath merged commit 196a544 into main Sep 3, 2026
35 of 37 checks passed
@hyperpolymath
hyperpolymath deleted the chore/smtp-notify-action branch September 3, 2026 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant