Skip to content

chore(ci): repoint push-email-notify to smtp-notify-action - #60

Merged
hyperpolymath merged 1 commit into
mainfrom
chore/smtp-notify-action
Sep 3, 2026
Merged

chore(ci): repoint push-email-notify to smtp-notify-action#60
hyperpolymath merged 1 commit into
mainfrom
chore/smtp-notify-action

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Replaces dawidd6/action-send-mail with hyperpolymath/smtp-notify-action v0.2.0 (tag commit ede1191ef6ff3ac02c4f4d9efdf837ee517e11d7), per the 2026-09-02 ruling (standards spec §5.5/§9, PR hyperpolymath/standards#725). The whole file is replaced with the rsr-template-repo canonical, which — besides the uses: line — restricts the trigger to branch pushes (tag and deletion payloads mislabel Branch:/head_commit), sets timeout-minutes: 5, carries a deliberately per-run concurrency group, and grants only contents: read. How many of those are actual changes here depends on how far this repo's copy had drifted — read the diff, not this list. Dormant gating on vars.PUSH_EMAIL_ENABLED == 'true' is unchanged. Line 1 SPDX header kept as it was.

Engine: .git-private-farm/scripts/smtp-notify-sweep.sh. Verification for this repo: regime=no-lock changed=.github/workflows/push-email-notify.yml, sig=G fa7b404 canon=543fc1474b54 base=main
(pristine/post = gh actions-lock --no-fix validity before/after; repair = the lock was already invalid before this change and is valid after it.)

🤖 Generated with Claude Code

Replaces dawidd6/action-send-mail with hyperpolymath/smtp-notify-action v0.2.0 (ede1191ef6ff3ac02c4f4d9efdf837ee517e11d7) per the 2026-09-02 ruling; file is the rsr-template-repo canonical (dormant gating on vars.PUSH_EMAIL_ENABLED unchanged). regime=no-lock changed=.github/workflows/push-email-notify.yml,

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: a9f24ffe-8a0d-4c8e-8eb5-e783da23ec8d

📥 Commits

Reviewing files that changed from the base of the PR and between b186ba7 and fa7b404.

📒 Files selected for processing (1)
  • .github/workflows/push-email-notify.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (24)
  • GitHub Check: scan / Hypatia Neurosymbolic Analysis
  • GitHub Check: scan / shell-secrets
  • GitHub Check: scan / rust-secrets
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: scan / gitleaks
  • GitHub Check: governance / Guix primary / Nix fallback policy
  • GitHub Check: governance / Trusted-base reduction policy
  • GitHub Check: governance / Licence consistency
  • GitHub Check: governance / Well-Known (RFC 9116 + RSR)
  • GitHub Check: governance / Security policy checks
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: rust-ci / Detect Cargo.toml
  • GitHub Check: Hypatia neurosymbolic scan
  • GitHub Check: Validate eclexiaiser manifest
  • GitHub Check: Validate K9 contracts
  • GitHub Check: analyze (actions, none)
  • GitHub Check: Empty-linter (invisible characters)
  • GitHub Check: panic-attack assail
  • GitHub Check: Groove manifest check
  • GitHub Check: Zig FFI builds + tests (Zig 0.14.0)
  • GitHub Check: Validate A2ML manifests
  • GitHub Check: ABI ↔ FFI structural conformance
🔇 Additional comments (3)
.github/workflows/push-email-notify.yml (3)

6-10: LGTM!

Also applies to: 16-31, 39-39


15-15: 🎯 Functional Correctness

No change is required. GitHub Actions does not trigger a push workflow for branch-deletion events; use the separate delete event to handle deletions.


42-42: 🗄️ Data Integrity & Integration

No input-contract mismatch is established.

The pinned commit is reachable, defines all nine inputs, and accepts space-separated recipients. secure: true selects implicit TLS. The value of secrets.SMTP_PORT is not present in the repository, so a port mismatch cannot be established.


📝 Summary

Summary by CodeRabbit

  • New Features

    • Push-triggered email notifications are available again after the temporary freeze.
    • Notifications now apply specifically to branch pushes.
  • Improvements

    • Email delivery uses an updated notification service for improved workflow handling.
    • Notification runs now have clearer execution limits and operate independently, helping prevent one run from delaying or cancelling another.

Walkthrough

The push email workflow now handles branch pushes only, uses per-run concurrency, limits the notification job to five minutes, and sends mail through a pinned hyperpolymath/smtp-notify-action release.

Changes

Push email notification workflow

Layer / File(s) Summary
Workflow notification delivery
.github/workflows/push-email-notify.yml
The workflow filters events to branch pushes, prevents queuing and cancellation between runs, adds a five-minute job timeout, updates explanatory comments, and replaces the email action while preserving its inputs.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to fa7b4

The workflow updates its pinned SMTP notification action while retaining the existing notification gate. No merge-blocking risk is currently identified.

Poem

A rabbit checks the branch at dawn
Tags and deletions hop along
Each run keeps its own small space
Five minutes mark the sending pace
SMTP carries mail away
The workflow rests until next day

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the workflow replacement and includes verification details, but it does not follow the required template headings or include the RSR Quality Checklist. Add the required ## Summary, ## Changes, ## RSR Quality Checklist, and ## Testing sections. Complete each applicable checklist item, including tests, formatting, linting, SPDX headers, dependency review, and secret checks. Add scree…
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the main change: repointing the push email notification workflow to smtp-notify-action.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Resolution

Add the required ## Summary, ## Changes, ## RSR Quality Checklist, and ## Testing sections. Complete each applicable checklist item, including tests, formatting, linting, SPDX headers, dependency review, and secret checks. Add screenshots or terminal output if applicable; otherwise state that they are not applicable.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

sonarqubecloud Bot commented Sep 3, 2026

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath merged commit 515f119 into main Sep 3, 2026
34 of 36 checks passed
@hyperpolymath
hyperpolymath deleted the chore/smtp-notify-action branch September 3, 2026 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant