Conversation
`man/graph.motifs.Rd` and `man/motifs.Rd` showed `motifs_randesu_callback_closure()` as the link text for a reference whose anchor is `#igraph_motifs_randesu_callback`. The displayed name and the destination disagreed. `_closure` is an R-side implementation detail: the generated wrapper is `motifs_randesu_callback_closure_impl()` in R/aaa-motifs.R. There is no such C symbol -- the link cache lists only `igraph_motifs_randesu_callback` -- so the text named something that does not exist in the C documentation being linked to. The current `igraph.r2cdocs` roclet derives the text from the symbol and gets this right. Regenerating is the whole change; no source was edited. The stale text was committed on 2026-08-04 in "docs: Revdep results before PR", by a regeneration under an older roclet. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WWhverMTZZKgEpUuTK117m
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing:
mainalready has this fix. Commit87885a001a("chore: Auto-update from GitHub Actions") made the identical two-line change toman/motifs.Rdandman/graph.motifs.Rd, somain'smotifs.Rdcontains nomotifs_randesu_callback_closureat all. This repository's CI roxygenizes and commits back, and that mechanism corrected the drift on its own while this PR was open.The analysis stands even though the change is no longer needed, and two parts of it are worth keeping on the record:
The fix was right for the right reason.
igraph_motifs_randesu_callback_closure()is a rigraph-side wrapper defined insrc/rcallback.c, not a C-library symbol, so the link text named a function that does not exist in the documentation it pointed at.tools/rebuild-cats.Randtools/split-aaa-auto.Rboth carry the..._closure→...mapping explicitly, under a comment saying it was verified againstsrc/rcallback.c.The
man/as_phylo.Rdclaim in #2903 is wrong and should be disregarded. That PR reports three files drifting on a pristine regeneration. Only two did.as_phylo()carries@inheritParams ape::as.phylo, and ape — a declaredSuggests— was not installed in the environment that made the observation, so roxygen2 silently resolved the inherited...to nothing and regeneration deleted\item{...}{further arguments to be passed to or from other methods.}. Since\usage{}isas_phylo(x, ...), committing that would have left...undocumented and trippedR CMD check. With ape installed, that file regenerates byte-identical to what is committed.🤖 Generated with Claude Code
https://claude.ai/code/session_01WWhverMTZZKgEpUuTK117m