Repository navigation
Fix if-let-guard compile error on stable Rust - #1
Merged
Merged
Conversation
CalendarEvent and RelayStatus construction used if-let guards inside match arms, an unstable feature not available on stable rustc. Rewrite both as a nested match on the fallible conversions instead, with identical accept/reject behaviour. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D95PWA2fdNfg7nUvUHBeMi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CalendarEventandRelayStatusconstruction incrates/nscript-runtime/src/lib.rsusedif letguards insidematcharms, an unstable Rust feature not available on stablerustc. This kept the workspace from compiling at all on stable toolchains.matchon the fallibleu64/u8conversions instead, with identical accept/reject behaviour (falls back tovalue.clone()on overflow, exactly as before).Test plan
cargo build --workspacesucceeds on stablerustc 1.94.1cargo test --workspace— all tests pass (248 passed, 1 ignored, across all crates)🤖 Generated with Claude Code
https://claude.ai/code/session_01D95PWA2fdNfg7nUvUHBeMi
Generated by Claude Code