Skip to content

Update windows makefile and doc (vcpkg) - #33

Merged
adamdickmeiss merged 2 commits into
masterfrom
vcpkg-packages
Oct 26, 2026
Merged

adamdickmeiss merged 2 commits into
masterfrom
vcpkg-packages

Conversation

@adamdickmeiss

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new architecture targets neither select nor validate the compiler architecture, so they can silently produce binaries for the wrong platform.

1 open issue
What changed in this PR

This PR updates Windows build support for YAZ++ and scopes an MSVC warning suppression around exported ZOOM exception classes.

Changes:

  • Adds architecture defaults and make32 / make64 targets.
  • Copies YAZ runtime DLLs after linking client executables.
  • Documents runtime compatibility requirements and suppresses warning C4251 around exported exceptions.
File Description
zoom/​master-header Adds scoped MSVC warning suppression and a runtime compatibility comment.
win/​makefile Adds architecture settings, build targets, and runtime DLL copying.

Review effort: Balanced

Comment thread win/makefile Resolved
@adamdickmeiss
adamdickmeiss merged commit f515951 into master Oct 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants