Conversation
Define empty, unbounded, and conditional unbounded date ranges on the connector-owned CompilerDialect. Use those primitives from query composition and remove the duplicate legacy function-provider implementations. Add focused tests for the shared range expressions. Co-authored-by: Codex GPT-5.6-sol <codex@openai.com>
Compose joins, negation, and date aggregation from connector-owned IR and the resolved entity schema. Keep the backend wrapper limited to converting legacy query children and ID configuration before delegating. Add connector-level tests for positive joins and both negation strategies. Co-authored-by: Codex GPT-5.6-sol <codex@openai.com>
Build the final aggregated query step from connector-owned IR while leaving legacy query resolution, result metadata, and rendering orchestration in the backend converter. Avoid duplicating explicit selects when joining additional result columns. Always aggregate explicit selects and only add an empty validity projection when the result includes dates. Co-authored-by: Codex GPT-5.6-sol <codex@openai.com>
Represent resolved external entity uploads in the framework-neutral query model and compile their IDs, date ranges, restrictions, and result values into connector-owned query-step IR. Keep upload resolution in the legacy backend adapter and extend the dialect contract with the literal rendering capabilities required by external nodes. Co-authored-by: Codex GPT-5.6-sol <codex@openai.com>
Make runtime conversion dispatch independent of the legacy backend context so it can support connector-owned converters for resolved model operations. Keep legacy node conversion as a backend adapter and verify that dispatch selects exactly one matching converter. Co-authored-by: Codex GPT-5.6-sol <codex@openai.com>
Represent all-entities queries in the resolved query model and compile their entity ID and empty validity range from the resolved entity schema. Translate legacy ID configuration into EntitySchema at the backend boundary. Reuse the same entity-table and primary-ID mapping for all-entities queries and negation anti-joins. Co-authored-by: Codex GPT-5.6-sol <codex@openai.com>
Compose conjunctions and disjunctions from compiled child steps in the SQL connector, including date aggregation, negation handling, and optional existence projections. Keep traversal of legacy query DTOs in backend adapters and honor an explicit false value for existence projection. Co-authored-by: Codex GPT-5.6-sol <codex@openai.com>
Use Lombok utility classes for connector types that expose only static model helpers, compiler operations, and rendering functions. Remove their manual private constructors so the non-instantiable intent is declared consistently. Co-authored-by: Codex GPT-5.6-sol <codex@openai.com>
Move the concept compilation CTE vocabulary into the connector's internal IR package. Keep the legacy backend conversion pipeline as a consumer while the remaining concept compiler implementation is extracted incrementally. Co-authored-by: Codex GPT-5.6-sol <codex@openai.com>
Move connector and concept select bundles together with staged filter output into the connector's internal concept IR package. Keep legacy converters as consumers while concept compilation is extracted incrementally. Co-authored-by: Codex GPT-5.6-sol <codex@openai.com>
Move the shared aggregation projection state into the connector's internal concept IR package. Remove its legacy model references and keep the backend aggregation converters as consumers during the incremental extraction. Co-authored-by: Codex GPT-5.6-sol <codex@openai.com>
Move the SQL calendar interval amounts into the connector's dialect package. Keep legacy form stratification, aggregation, and database-specific renderers as consumers while their implementations are extracted incrementally. Co-authored-by: Codex GPT-5.6-sol <codex@openai.com>
Move shared form fields and interval offsets into the connector's internal representation. Keep legacy form converters and dialect implementations as consumers while their compilation logic is extracted incrementally. Co-authored-by: Codex GPT-5.6-sol <codex@openai.com>
Move aggregation-select and aggregation-filter query-step construction into the connector compiler. Keep the backend CTE wrappers responsible only for legacy context adaptation and CTE lifecycle handling. Co-authored-by: Codex GPT-5.6-sol <codex@openai.com>
Move final concept select merging, connector aggregation, predecessor joins, grouping, and negation into the connector compiler. Keep legacy select conversion and interval-step adaptation in the backend. Co-authored-by: Codex GPT-5.6-sol <codex@openai.com>
Move SQL-resolved preprocessing input and CTE construction into the connector compiler. Keep the backend adapter responsible for resolving legacy context, and replace the neutral dialect join helper with direct jOOQ joins. Co-authored-by: Codex GPT-5.6-sol <codex@openai.com>
Move interval-packing select branch construction into the connector compiler. Keep the backend adapter responsible for legacy select conversion and remove its now-unused conversion-context dependency. Co-authored-by: Codex GPT-5.6-sol <codex@openai.com>
Move interval packing and auxiliary predecessor joins into the connector compiler behind a SQL-resolved input. Keep the backend responsible for adapting legacy select and filter groups into their distinct branch inputs. Co-authored-by: Codex GPT-5.6-sol <codex@openai.com>
Compile connector CTE phases and predecessor wiring from a SQL-resolved pipeline input. Reduce the legacy concept converter to an input adapter and remove its backend-specific pipeline state and phase classes. Co-authored-by: Codex GPT-5.6-sol <codex@openai.com>
Let the connector compile the final concept CTE and its optional interval select branch from SQL-resolved input. Keep the legacy backend responsible for converting concept selects and remove its concept-branch adapter. Co-authored-by: Codex GPT-5.6-sol <codex@openai.com>
Compile arbitrary interval-packed select projections in the connector and expose single-column range expansion as a compiler dialect capability. Keep the backend dialect as a temporary delegate to its existing implementation. Co-authored-by: Codex GPT-5.6-sol <codex@openai.com>
Move auxiliary CTE planning and arbitrary date-range packing into the SQL connector. Return neutral preparation IR so the legacy adapter only creates the select or filter aggregation expression. Co-authored-by: Codex GPT-5.6-sol <codex@openai.com>
Move connector and final-concept CTE graph planning into the SQL connector. Keep the legacy table path responsible for model inspection and attaching backend-specific connector metadata. Co-authored-by: Codex GPT-5.6-sol <codex@openai.com>
Assemble preprocessing inputs, event-date selects, and additional predecessors inside the SQL connector. Carry the generated connector name with its CTE plan so the legacy adapter only retains backend connector metadata. Co-authored-by: Codex GPT-5.6-sol <codex@openai.com>
Expose connector-owned SqlTables directly to legacy filter conversion and shared aggregation helpers. Keep ConnectorSqlTables limited to select paths that still require backend Connector metadata. Co-authored-by: Codex GPT-5.6-sol <codex@openai.com>
Carry physical connector tables through CTE planning and preprocessing so SQL generation preserves schema-qualified names from resolved models. Keep the legacy string planning entry point for the backend adapter, and derive the entity table from its resolved primary-ID column. Co-authored-by: Codex GPT-5.6-sol <codex@openai.com>
Return complete query steps from connector CTE compilation instead of exposing mutable builders across method boundaries. Let concept and date aggregation stages own their CTE metadata and predecessor relationships, and keep individual connector stages package-private. Co-authored-by: Codex GPT-5.6-sol <codex@openai.com>
Convert built-in resolved conditions into compiler IR through the connector's runtime dispatcher and allow extensions to contribute converters for their own condition types. Expose regular-expression matching as a compiler dialect capability while preserving the legacy backend dialect implementations. Mark the prefix-range model as deprecated because matching-statistics expression generation does not support it. Co-authored-by: Codex GPT-5.6-sol <codex@openai.com>
Convert resolved string-value and numeric-range filters into event-level connector predicates. Preserve zero-based substring semantics when building SQL expressions and provide the compiler context and dispatcher boundary for extension-defined filter converters. Document the preprocessing, event, and post-aggregation condition buckets consumed by the connector pipeline. Co-authored-by: Codex GPT-5.6-sol <codex@openai.com>
Convert resolved flag and date-distance filters into event-level connector predicates. Keep range and flag semantics in the connector while delegating database-specific date-distance expressions to the compiler dialect and preserving the legacy backend adapter. Co-authored-by: Codex GPT-5.6-sol <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.