Skip to content

fix(core): allowed metrics interval up to 60s - #2713

Open
kirrg001 wants to merge 4 commits into
mainfrom
fix-poll-rate-limitation
Open

fix(core): allowed metrics interval up to 60s#2713
kirrg001 wants to merge 4 commits into
mainfrom
fix-poll-rate-limitation

Conversation

@kirrg001

@kirrg001 kirrg001 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

refs https://jsw.ibm.com/browse/INSTA-102260

before: 5s
after: upto 60s

Allowed poll rate values: 1s, 5s, 10s, 20s, 30s, 60s, 120s, 180s, 240s, 300s, 360s, 420s, 480s, 540s, 600s
ref from https://instana.slack.com/archives/C09S45LHBSQ/p1785315424877589?thread_ts=1784806406.182009&cid=C09S45LHBSQ

EDIT:

updated the config upto 60s, will add support for 60 - 600 once BE is capable

aryamohanan
aryamohanan previously approved these changes Aug 18, 2026

@aryamohanan aryamohanan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kirrg001 kirrg001 changed the title fix(core): allowed metrics interval up to 60s fix(core): allowed metrics interval up to 600s Aug 21, 2026
Comment thread packages/core/src/config/index.js Outdated
const allowedSecretMatchers = ['equals', 'equals-ignore-case', 'contains', 'contains-ignore-case', 'regex', 'none'];

const transmissionDelayMaxValue = 5000;
const transmissionDelayMaxValue = 60 * 1000;

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be 600s. There was a spec change.

@abhilash-sivan
abhilash-sivan marked this pull request as ready for review August 31, 2026 07:01
@abhilash-sivan
abhilash-sivan requested a review from a team as a code owner August 31, 2026 07:01
@abhilash-sivan abhilash-sivan changed the title fix(core): allowed metrics interval up to 600s fix(core): allowed metrics interval up to 60s Aug 31, 2026
@abhilash-sivan
abhilash-sivan force-pushed the fix-poll-rate-limitation branch from c80332e to 0037a5e Compare September 4, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants