Repository navigation
[raft] Implement admin API server for cluster membership - #1781
Draft
MariemBaccari wants to merge 4 commits into
Draft
MariemBaccari wants to merge 4 commits into
MariemBaccari wants to merge 4 commits into
Conversation
MariemBaccari
force-pushed
the
admin_server
branch
14 times, most recently
from
October 15, 2026 12:46
c352342 to
c17b932
Compare
MariemBaccari
marked this pull request as ready for review
October 15, 2026 13:43
MariemBaccari
force-pushed
the
admin_server
branch
from
October 21, 2026 06:58
c17b932 to
b2fbf66
Compare
MariemBaccari
marked this pull request as draft
October 22, 2026 13:28
the-glu
reviewed
Oct 22, 2026
| enableMetrics = flag.Bool("enable_metrics", false, "Enable metric endpoint") | ||
| enableTracing = flag.Bool("enable_tracing", false, "Enable tracing") | ||
| metricsListeningAddress = flag.String("metrics_addr", ":8079", "Address and port that the for the prometheus-compatible metric service binds to and listens on for incoming connections") | ||
| adminAddress = flag.String("admin_addr", ":8078", "Address and port that the admin API (used by dssctl) binds to and listens on for incoming connections. TODO: The API is not authenticated yet.") |
Member
There was a problem hiding this comment.
I would limit it to 127.0.0.1:8078, especially since it's not protected
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #1776 and partially addresses #1719 by implementing the admin API for cluster membership changes server.