Repository navigation
[raft] Implement admin API client for cluster membership - #1787
Draft
MariemBaccari wants to merge 6 commits into
Draft
MariemBaccari wants to merge 6 commits into
MariemBaccari wants to merge 6 commits into
Conversation
MariemBaccari
force-pushed
the
membership_client
branch
2 times, most recently
from
October 15, 2026 11:14
473a642 to
3ea51a3
Compare
MariemBaccari
force-pushed
the
membership_client
branch
2 times, most recently
from
October 15, 2026 12:52
9f7ef18 to
e8adbd5
Compare
MariemBaccari
force-pushed
the
membership_client
branch
from
October 15, 2026 12:56
e8adbd5 to
97798ec
Compare
MariemBaccari
marked this pull request as ready for review
October 15, 2026 13:44
the-glu
reviewed
Oct 22, 2026
| ) | ||
|
|
||
| var ( | ||
| adminURL = flag.String("admin_url", "http://localhost:8078", "URL of the admin API of core-service, matching its --admin_addr") |
Member
There was a problem hiding this comment.
nit: matching its --admin_addr implies the ip/port should the same but it's not really the case, it should be the endpoint there it's reachable and my be diffrenet.
MariemBaccari
marked this pull request as draft
October 22, 2026 13:28
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #1786 and partially addresses #1719 by implementing the admin API client for cluster membership requests.