Repository navigation
Enforce request-level scopes for SCD subscription notifications - #1788
Merged
BenjaminPelletier merged 2 commits intoOct 20, 2026
Merged
BenjaminPelletier merged 2 commits into
BenjaminPelletier merged 2 commits into
Conversation
|
|
BenjaminPelletier
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Require
utm.strategic_coordinationwhen an SCD subscription requests Operational Intent notifications.Require
utm.constraint_processingwhen it requests Constraint notifications.Apply the same validation to create and update requests before payload construction or storage access.
Behavior
Requests without every required scope return HTTP 403.
The table test covers valid single-scope requests, a valid dual-scope request, both cross-scope cases, and both single-scope requests that ask for both notification classes.
Tests
go test -count=1 -run TestValidateRequestedSubscriptionScopes -v ./pkg/scdgo test -count=1 ./pkg/... ./cmds/...