Repository navigation
[raft][metrics] Timestamp the context - #1795
Merged
Merged
Conversation
MariemBaccari
marked this pull request as ready for review
October 19, 2026 08:05
mickmis
approved these changes
Oct 19, 2026
mickmis
left a comment
mickmis
left a comment
Contributor
There was a problem hiding this comment.
LGTM to avoid the panic.
But that makes me wonder whether we actually want to dispatch a read proposal to get those metrics. For a potential future optimization, what would you think of reading this from the memstore instead? (we'd need to see how to deal with the interfaces though) Because in the end I do not think we really care about this read being super up-to-date.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #1794 by timestamping the context of the metric collection fetcher since those requests do not go through the timestamp middleware.